search

advplyr / audiobookshelf

Self-hosted audiobook and podcast server
https://audiobookshelf.org
GNU General Public License v3.0
6.81k stars 481 forks source link

[Enhancement]: Update "In Progress" Series Filter to include started but not finished #3220

Open some-guy-23 opened 3 months ago

some-guy-23 commented 3 months ago

What happened?

When on the Series page, when I use the drop-down filter and select "Series Progress -> in-progress", I only see the series of the book I'm currently listening to (1 result).

What did you expect to happen?

I'd expect to see a full list of all series where I've listened to at least 1 book in that series (but not completed the series yet). So that I can pick what series to continue next.

This is basically an alternative once the "Continue Series" line overflows the Home page (so can't see all in-progress / continue series).

Steps to reproduce the issue

  1. Go to Series page
  2. Select filter Series Progress -> in-progress

Audiobookshelf version

v2.11.0

How are you running audiobookshelf?

Windows Tray App

What OS is your Audiobookshelf server hosted from?

Windows

If the issue is being seen in the UI, what browsers are you seeing the problem on?

Chrome

Logs

No response

Additional Notes

No response

some-guy-23 commented 3 months ago

After submitting this, occurred to me maybe this is the intention of the "Not Finished" filter behavior? However, for the "Not Finished" filter, it also shows all series that haven't been started yet.

So, there doesn't seem to currently be a way to view all series that are "Started but not Finished" (which I'd think is a synonymous with "In Progress").

sydlexius commented 3 months ago

Related to this, when I'm on the "In-progress" filter for series, it shows series where all items are 100% read. As there's also a "Finished" filter under "Series Progress", seeing finished series under "In-Progress" just creates more noise, IMO.

As for the behavior that you're experiencing, I can't reproduce this issue on my instance (docker, v2.11.0). I see multiple series when selecting the same filter.

some-guy-23 commented 3 months ago

As for the behavior that you're experiencing, I can't reproduce this issue on my instance (docker, v2.11.0). I see multiple series when selecting the same filter.

I guess I should clarify, it looks like it can show multiple series, but only when I have individual books that are "in progress" in the series (typically I'm only listening to one book at a time).

Are you seeing series listed where, none of the books in the series are currently in-progress?

sydlexius commented 3 months ago

I don't see any series that have any books without progress. Everything has one or more partially- or fully-complete books.

some-guy-23 commented 3 months ago

Yeah so that's my root issue, I have quite a few (unfinished) series with totally completed books, but none of them show up.

I'm wondering if it's related to having marked the books as completed, as opposed to actually listening to them (listened to them before I used ABS).

Update: tried re-playing book 1 of a series, and while in-progress it will also display the series as in-progress. However, as soon as book 1 is finished, the whole series disappears from "in-progress" (even though it shows book 1 completed, and has additional unread books).

advplyr commented 3 months ago

This is how it was designed because it matches the library filters available for progress so the query is the same.

I understand what you mean and why it would make sense to interpret it that way.