search

advplyr / audiobookshelf

Self-hosted audiobook and podcast server
https://audiobookshelf.org
GNU General Public License v3.0
6.58k stars 467 forks source link

[Bug]: 2.13.x introduced something that breaks the user linking on the mobile app #3490

Open FreedomBen opened 2 weeks ago

FreedomBen commented 2 weeks ago

What happened?

After upgrading from 2.12.3 to 2.13.4, the mobile app no longer recognizes that the local user is the same as the remote user, and thus we get the message saying that progress will not be synced (and it really isn't).

What did you expect to happen?

Progress continues to sync with local media as it did before.

Steps to reproduce the issue

  1. Upgrade to 2.13.4
  2. Download an audiobook for offline/local playback
  3. Observe the message saying that progress won't be synced because the book was downloaded by a different user (even though it wasn't)

Audiobookshelf version

v2.13.4

How are you running audiobookshelf?

Docker

What OS is your Audiobookshelf server hosted from?

Linux

If the issue is being seen in the UI, what browsers are you seeing the problem on?

None

Logs

Nothing relevant in the logs

Additional Notes

Downgrading back to 2.12.3 fixes the issue

FreedomBen commented 2 weeks ago

Well damn, standby on this one. I'm currently working on narrowing down the exact version that introduced the bug and after downgrading and working my way back up, it's now working on 2.13.4. I'll play with it a bit more but if I can't reproduce then I'll close this.

FreedomBen commented 2 weeks ago

Ok now after doing a full library scan, it's back. I need to re-test the other versions now with also doing a full scan, so the debugging continues...

FreedomBen commented 2 weeks ago

Confirmed: bug is not present in 2.12.3, but is present in 2.13.4. Will continue the narrowing process.

nichwall commented 2 weeks ago

2.13.x included cleaning up old data models from before the SQLite database, so may be related to something there. I assume the issue does not go away on 2.14.0 (released 3 days ago)?

FreedomBen commented 1 week ago

Had to suspend debugging effort because my hard drive filled up. Btw, BTRFS really doesn't do well when full. The read/write speeds slowed down to absurd levels, which made it impossible to boot from the drive. I booted with a live disc and started cleaning stuff up, but it took days to move 20 GB of data. Finally back up so will resume debugging as I have time.

FreedomBen commented 1 week ago

Ok, confirmed that the bug was introduced in 2.13.0. It is not present in 2.12.3.

And damn, there's a lot of changes between the two... I'll look through the changes and see if anything stands out, but I'm not super optimistic.

https://github.com/advplyr/audiobookshelf/compare/v2.12.3...v2.13.0