search

advweb-grp1 / advanced-web-final-year-project

Final year advanced web develop unit project
MIT License
1 stars 0 forks source link

added eslint.js #22

Closed AymanReh closed 1 year ago

AymanReh commented 1 year ago

Fixed styling errors in src folder Added eslintrc.js Made sure it works alongside ESlint plugin.

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit 6f007a4):

https://adv-web-grp1--pr22-core-eslint-kigflzbv.web.app

(expires Mon, 03 Apr 2023 19:41:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e45f8bd17b7de44787580bea572e36aa09784b8c

rwx-yxu commented 1 year ago

Attaching reviewers

rwx-yxu commented 1 year ago

I actually noticed that the linting hasn't been added to the workflow. Refer to this comment https://github.com/advweb-grp1/advanced-web-final-year-project/issues/19#issuecomment-1478774709

LiamSingh64 commented 1 year ago

Had to run npm install eslint-plugin-import@latest --save-dev for command npm run lint to work. Can this just be added to the package.json?

advweb-grp1 commented 1 year ago

Already have eslint-plugin-import in package.json

advweb-grp1 commented 1 year ago

Not sure if the linting is ran when the command npm run ci part. Need to research

advweb-grp1 commented 1 year ago

Not sure if the linting is ran when the command npm run ci part. Need to research