core/layout

[D4ni3l8]

This is the initial homepage layout.

[github-actions[bot]]

Visit the preview URL for this PR (updated for commit cf157b6):

https://adv-web-grp1--pr24-18-corelayout-4o8xl0yg.web.app

_{(expires Fri, 07 Apr 2023 18:34:42 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: e45f8bd17b7de44787580bea572e36aa09784b8c}

[D4ni3l8]

The homepage is meant to look something like this

[D4ni3l8]

I have added the navigation bar links in HomeView.vue, I also added the HomeView tag in App.vue to display the homepage. The problem is that when the user presses the links in the navbar, the page remains the same. For example, when i click on login link, it still shows the homepage.

[rwx-yxu]

Reviewing current code implementation.

[rwx-yxu]

I am not entirely okay on the current implementation of App.Vue. All the layout has been defined in the HomeView.Vue file.

[rwx-yxu]

Reason why the views are not being routed is because the view file doesn't render routing views. The HomeView.Vue is a static file which hard codes that file so the buttons currently do nothing

[rwx-yxu]

Build fail log from action

error during build:
RollupError: Could not resolve "./views/Homeview.vue" from "src/App.vue"
    at error (file:///home/runner/work/advanced-web-final-year-project/advanced-web-final-year-project/node_modules/rollup/dist/es/shared/node-entry.js:2125:30)
    at ModuleLoader.handleInvalidResolvedId (file:///home/runner/work/advanced-web-final-year-project/advanced-web-final-year-project/node_modules/rollup/dist/es/shared/node-entry.js:[23](https://github.com/advweb-grp1/advanced-web-final-year-project/actions/runs/4566231636/jobs/8058440400?pr=24#step:3:24)777:[24](https://github.com/advweb-grp1/advanced-web-final-year-project/actions/runs/4566231636/jobs/8058440400?pr=24#step:3:25))
    at file:///home/runner/work/advanced-web-final-year-project/advanced-web-final-year-project/node_modules/rollup/dist/es/shared/node-entry.js:23739:[26](https://github.com/advweb-grp1/advanced-web-final-year-project/actions/runs/4566231636/jobs/8058440400?pr=24#step:3:27)
Error: Process completed with exit code 1.

[rwx-yxu]

I am gonna move the nav bar into app.Vue and use bootstrap to make the general layout along whereby there will be a router-view in a main tag

[rwx-yxu]

Wont pass linting in its current state as well.

[rwx-yxu]

Removing the main.css that is being imported in main.js. The default css created by vue init was probs the source of some of the issues that Daniel was facing which pushed him to avoid App.vue. Before: After removing main.css

[rwx-yxu]

Need to do some clean up:

• Remove the bootstrap component entirely. That component was just a test to prove bootstrap integration. This is no longer needed anymore.
• Remove reset from the nav list since the site map shows that the reset is only accessible from the login and register pages.
• Remove home option on the nav bar because you can go to home by pressing on the bold 'cardiomyopathy' button

[rwx-yxu]

Moving nav bar into its own component file. It's a chance to write up a vitest as well to test it out.

[rwx-yxu]

looking at the changes required, its safer to raise a separate pull request to add testing. Will definately be hitting conflics with #23 because I need to modify vitetest.config.js to remove the cardiomyopathy directory.

[rwx-yxu]

Still going to push up NavBar.vue. Probs best to raise two separate pull requests. One for navbar testing and another for clean to remove the rest of the default welcome stuff. I would like to do it in this pull request but Liam already has removed some files like the icons already and went ahead to remove one of the welcome files. Best to keep the pull requests specific to their purpose rather than to pollute it with additional extras on top.