advweb-grp1 / advanced-web-final-year-project

Final year advanced web develop unit project
MIT License
1 stars 0 forks source link

core/cleanup #30

Closed D4ni3l8 closed 1 year ago

D4ni3l8 commented 1 year ago

I created the composable.js file in the composables folder. I also got rid of the vue init starter files. This could need some changes.

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit 515137b):

https://adv-web-grp1--pr30-core-cleanup-vydf465i.web.app

(expires Thu, 13 Apr 2023 11:17:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e45f8bd17b7de44787580bea572e36aa09784b8c

rwx-yxu commented 1 year ago

Why have you not removed HelloWorld.vue and WelcomeItem.vue? Were they not auto generated?

rwx-yxu commented 1 year ago

Failing build because there are no test files

rwx-yxu commented 1 year ago

Adding a nav bar unit test.

rwx-yxu commented 1 year ago

117:13 error 'response' is assigned a value but never used no-unused-vars Current failing error. I am going to comment out the entire file because it is not going to be in use.