advweb-grp1 / advanced-web-final-year-project

Final year advanced web develop unit project
MIT License
1 stars 0 forks source link

Feature/reset-password #32

Closed LiamSingh64 closed 1 year ago

LiamSingh64 commented 1 year ago

This PR:

LiamSingh64 commented 1 year ago

should I add a router-link that goes BACK to the login page?

LiamSingh64 commented 1 year ago

Still need to add a proper modal (probs with Bootstrap) or is it not needed?

rwx-yxu commented 1 year ago

Actual error:

FirebaseError: The following error originated from your application code, not from Cypress.

Might very well be an error from one of the other commands rather than cypress specifically.

rwx-yxu commented 1 year ago

I can run cypress tests on local machine but the action runner has an issue with the auth:

> Firebase: Error (auth/invalid-api-key).

Could be related to the line change for

const firebaseAuth = getAuth(app);
rwx-yxu commented 1 year ago

although the cypress test does "pass", the actual video output doesn't even show the home page. Compared to the other working braches.

rwx-yxu commented 1 year ago

Code just doesn't work. Need to rewrite way that reset link is being set.

rwx-yxu commented 1 year ago

Still failing... I'll review the secrets from firebase project.

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit a575b95):

https://adv-web-grp1--pr32-feature-reset-passwo-ys62skhf.web.app

(expires Thu, 20 Apr 2023 11:13:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e45f8bd17b7de44787580bea572e36aa09784b8c