Closed rwx-yxu closed 1 year ago
Visit the preview URL for this PR (updated for commit ff977f0):
https://adv-web-grp1--pr33-feature-login-me5mxqwk.web.app
(expires Wed, 19 Apr 2023 13:28:57 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: e45f8bd17b7de44787580bea572e36aa09784b8c
Build has passed, this means that there is definitely an issue with the way that firebase methods are being exported.
Ah, most likely is because I havent assigned the methods to a const to export the functions. Kind of strange how local cypress testing will allow for this to pass.
Build passed so it seems to be an isolated issue with the login view script setup with the way that I am importing the functions or something.
Removing eslint line 'plugin:import/recommended'
because it is causing all sorts of problems when trying to import things. Cannot use @ imports at all because eslint cannot resolve the import.
I somehow managed to get the same error on local machine.
Issue is the env vars not being present so it is fails when trying to get auth. Also, I need to pass app into getAuth.
this pull request will add the login page. Pull request also contains additional changes: