Feature/dashboard liam - Githubissues

advweb-grp1 / advanced-web-final-year-project

Final year advanced web develop unit project

MIT License

1 stars 0 forks source link

Feature/dashboard liam #37

Closed LiamSingh64 closed 1 year ago

LiamSingh64 commented 1 year ago

This PR:

~~Creates a composable that queries diabetes data from Firestore "diabetesData.js"~~
added <Suspense> to <router-view> for Lazy-Loading (needed for data querying on load)
Gets diabetes data on dashboard load
made Computed property for integer of "Percentage of participants with diabetes" https://github.com/advweb-grp1/advanced-web-final-year-project/issues/29#issuecomment-1506735631
added Pie Chart for "Prevalence of diabetes" https://github.com/advweb-grp1/advanced-web-final-year-project/issues/29#issuecomment-1506735631

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit a4b7c67):

https://adv-web-grp1--pr37-feature-dashboard-li-4qp359e7.web.app

_{(expires Sat, 29 Apr 2023 13:55:02 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: e45f8bd17b7de44787580bea572e36aa09784b8c}

LiamSingh64 commented 1 year ago

DON'T APPROVE! Last fix messed it up 😭

LiamSingh64 commented 1 year ago

b565c5c fixes ESLint issues so the project builds/deploys from Github Actions, but this fix now just returns undefined instead of the actual data

LiamSingh64 commented 1 year ago

let { total, withDiabetes } = await getDiabetesData(); worked fine, just ESLint gave Parsing Error so build failed

LiamSingh64 commented 1 year ago

[x] Need to refactor so it makes use of pinia store

LiamSingh64 commented 1 year ago

[x] Remove Composable diabetesData.js
[x] remove nave bar commit
[x] remove <suspense> and verify page still loads. If it does, remove it.