search

advweb-grp1 / advanced-web-final-year-project

Final year advanced web develop unit project
MIT License
1 stars 0 forks source link

Feature/user profile #51

Closed AymanReh closed 1 year ago

AymanReh commented 1 year ago

Added profile page added edit user page added validation to edit user page

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit 3cdb3cf):

https://adv-web-grp1--pr51-feature-user-profile-1qp11t54.web.app

(expires Mon, 01 May 2023 20:48:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e45f8bd17b7de44787580bea572e36aa09784b8c

rwx-yxu commented 1 year ago

Current screenshot of what profile page looks like. User info redacted. image image

rwx-yxu commented 1 year ago

The edit user profile page button is called "register" which is incorrect. The profile page itself design is too far in a singlar block so there is some screen real estate not being used. First name and surname should be on the same line as well as postcode and city along with phone number and institution. The edit profile should be a button rather than a link so just add class "btn btn-primary" to that element so it uses bootstrap styling.

rwx-yxu commented 1 year ago

Rather than 'forgotten password?', better to name it 'Reset Password' the user has already logged in so they know their password. That button is an option to change it to something else from their current one.

AymanReh commented 1 year ago

final view looks like this image

advweb-grp1 commented 1 year ago

Not sure why the current profile view is like this image Other fields are not present. Notified dev of this.

advweb-grp1 commented 1 year ago

The user info is being picked up when I go to the edit page

advweb-grp1 commented 1 year ago

Verified it works.