Feature/gene info - Githubissues

advweb-grp1 / advanced-web-final-year-project

Final year advanced web develop unit project

MIT License

1 stars 0 forks source link

Feature/gene info #54

Closed LiamSingh64 closed 1 year ago

LiamSingh64 commented 1 year ago

This PR:

Creates MutationsView which has a RadioGroup so only 1 Gene is selected at a time
Calls the corresponding API endpoints (https://github.com/advweb-grp1/advanced-web-final-year-project/issues/48#issuecomment-1518771526) everytime the button is clicked. (Store isn't used for this reason: https://github.com/advweb-grp1/advanced-web-final-year-project/issues/48#issuecomment-1524009279)
Resulting call is parsed for gene name, description and summary
Parsed data is displayed in a card
Route added to NavBar once the User has logged in

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit bcdbf1c):

https://adv-web-grp1--pr54-feature-geneinfo-ob950fq1.web.app

_{(expires Fri, 05 May 2023 09:23:10 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: e45f8bd17b7de44787580bea572e36aa09784b8c}

LiamSingh64 commented 1 year ago

I already mentioned it in the issue and at the top of this PR but an API call is made everytime the button is clicked instead of using a Store bcos endpoints were not reliably returning data whilst 'bulk' calling and Ayman couldn't figure out why

So this is either a WIP before we change it to use a store properly OR we just keep it like this bcos it works, isn't even slow and we have other priorities for this project... and our dissertations!

rwx-yxu commented 1 year ago

the mutations view should be available to everyone. Not just on log in.

rwx-yxu commented 1 year ago

some minor styling should be fixed The card header looks odd. There is some background colour coming through on the edges. Too wordy for the card. Header. Should just be the mutation name.

AymanReh commented 1 year ago

Final view for Gene info after styling changes: