svteichman commented 3 years ago

I changed is.na(X) to is.null(X). Now the example works and devtools::test() passes all tests. There is an issue with devtools::check, but I didn't see anything in the warning message related to betta_random so I'm hoping that this isn't something that I caused. But if so let me know!

adw96 commented 3 years ago

Looks fantastic @svteichman -- the warning message was related to the use of internal functions in lme4 without an import call -- added in commit ecd5d5c.

Two things

if there is any difference between lme4:::subbars and lme4::subbars ?I would rather replace the internal function call with the exported function call if possible
Could you also come up with a short example that illustrates the new functionality? Ideally it would go in the roxygen comment as an example and in vignettes/diversity-hypothesis-testing.Rmd

codecov-io commented 3 years ago

Codecov Report

Merging #95 (ecd5d5c) into master (c361108) will decrease coverage by 0.56%. The diff coverage is 27.77%.

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   90.35%   89.79%   -0.57%     
==========================================
  Files          28       28              
  Lines        2001     2018      +17     
==========================================
+ Hits         1808     1812       +4     
- Misses        193      206      +13

Impacted Files	Coverage Δ
R/model_betta.R	`88.57% <27.77%> (-8.99%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c361108...06d2736. Read the comment docs.

adw96 / breakaway

Betta random sarah #95

Codecov Report