adwiv / android-fat-aar

Gradle script that allows you to merge and embed dependencies in generted aar file
The Unlicense
1.46k stars 435 forks source link

Support Android plugin 2.2.0 #28

Closed jksiezni closed 8 years ago

jksiezni commented 8 years ago

I've updated script to work with Android plugin 2.2.0. Also, it includes support for multiple build variants, based on the work of mb-14. Other changes:

jksiezni commented 8 years ago

Hah, it appears my PR is no longer needed. :)

adwiv commented 8 years ago

Thanks.. I would like to see how you fixed the resource id issue.. maybe better than my hack. I'll add the multiple build variants once we check 2.2 compatibility works :)

jksiezni commented 8 years ago

Well, I didn't fix the resource id issue, because I do not use it. In fact, I had no idea, that this issue exists in the first place. ;)

jksiezni commented 8 years ago

Hi, I've found a different way of handling missing R classes from embedded libraries. You may want to look at my commit. It's a very simple workaround, where a new task build an embedded.jar file with missing R classes and puts it to the 'libs' directory.

adwiv commented 8 years ago

Hey that sounds great. It would be much much better than the current hack and I see no reason why it wouldn't work. Will check it out. Thanks.

On 07-Oct-2016 9:56 PM, "jksiezni" notifications@github.com wrote:

Hi, I've found a different way of handling missing R classes from embedded libraries. You may want to look at my commit. It's a very simple workaround, where a new task build an embedded.jar file with missing R classes and puts it to the 'libs' directory.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/adwiv/android-fat-aar/pull/28#issuecomment-252297836, or mute the thread https://github.com/notifications/unsubscribe-auth/AKfnZ8S3Pzq1iJX_zosuIaQvilVIfl_Iks5qxnLHgaJpZM4KFm2N .

adwiv commented 8 years ago

There were conflicts, so I had to copy the code instead of doing a merge. I am not that good with git merge.

The suggestion seems to work great. Thanks a lot.

adwiv commented 8 years ago

Added you in the credits section. You saved a big headache for me 👍