search

adyach / nakadi-docker

Dockerfile to containerize Nakadi
Apache License 2.0
8 stars 2 forks source link

Move repository to zalando-nakadi/nakadi-docker #6

Open otrosien opened 2 years ago

otrosien commented 2 years ago

Hey @adyach,

can we move this repo to the zalando-nakadi github org?

adyach commented 2 years ago

@otrosien maybe we can move it rather into the internal repo including file based plugging impl, wdyt ? also I do not know how hard it would be to distribute a new version.

otrosien commented 2 years ago

Not sure what the "file based plugging impl" is you're referring to. Regarding "how hard it would be to distribute a new version" do you mean getting users to change to a new docker location?

Regarding moving it to internal: Would you then push to opensource pierone or to the internal repo? The latter would be unfortunate to the opensource nakadi libs like fahrschein that need the docker image for end-to-end testing.

adyach commented 2 years ago

Not sure what the "file based plugging impl" is you're referring to.

there is an authz plugin to support authz config for testing https://github.com/adyach/nakadi-authz-file-plugin

Regarding "how hard it would be to distribute a new version" do you mean getting users to change to a new docker location?

yes

Regarding moving it to internal: Would you then push to opensource pierone or to the internal repo? The latter would be unfortunate to the opensource nakadi libs like fahrschein that need the docker image for end-to-end testing

in general, I worry that once nakadi-docker is moved to Zalando org, it will the time to move it to internal repo, because Nakadi moves to internal.

I do not have any objections moving Nakadi-docker to zalando-nakadi org.

otrosien commented 2 years ago

There already was a breaking change when moving from adyach/nakadi-docker:latest to ghcr.io/adyach/nakadi-docker/nakadi:latest -- I would say we keep a big note in the README, and could even create some automatic PRs for people's repos.