adyanth / splitwise-firefly-sync

Sync Splitwise expenses to Firefly III
13 stars 3 forks source link

Payments in foreign currency #10

Closed Sha-yol closed 4 weeks ago

Sha-yol commented 1 month ago

FF does not convert automatically between currencies, so requires adding both amount in foreign and native currency. What happens if the sync tries to add a SW expense in a non-native currency? I suggest the following should happen:

Another complication, which I think isn't handled right now: "native" and "foreign" is defined in SW at the user level, but on FF it is defined at the asset account level. So when adding a txn, should check whether the SW expense currency is native/foreign for the FF source account.

Sha-yol commented 1 month ago

Note: if manually revising on FF, need to resolve #4.

adyanth commented 1 month ago

Adding estimated conversion rates would require an additional (potentially paid) API to be interfaced with. Since both would need manual revision (because who is paying the exact exchange rate anyway), adding a dummy value with a custom tag sounds good to me.

The SW user's native currency should not matter, since each transaction would be in a specific currency at the end. But the FF asset account's native currency is the one to be handled correctly.

Sha-yol commented 1 month ago

Agree it's not needed to add an estimated conversion rate with an additional API. So the process should be:

adyanth commented 4 weeks ago

Fixed by https://github.com/adyanth/splitwise-firefly-sync/pull/13