adyeths / u2o

USFM to OSIS bible format converter.
The Unlicense
19 stars 6 forks source link

Closing tag verse eID misplaced if more than one title #108

Closed LAfricain closed 4 years ago

LAfricain commented 4 years ago

If a verse has more than one title the closing tag verse eID is misplaced:

<!-- s2 --><title type="x-s2">Une journée à Capharnaüm</title>
<verse eID="Mark.1.20" />
<!-- r --><title type="parallel"><reference type="parallel" osisRef="Matt.7.28-Matt.7.29 Luke.4.31-Luke.4.37">Mt 7,28-29; Lc 4,31-37 </reference></title>
<p>
<verse sID="Mark.1.21" osisID="Mark.1.21" n="21" /><w lemma="strong:G2532">Et</w>

Then it's not well ready by the sword frontend. If we move the tag to the right place then It's well read by the frontend:


<verse eID="Mark.1.20" />
<!-- s2 --><title type="x-s2">Une journée à Capharnaüm</title>
<!-- r --><title type="parallel"><reference type="parallel" osisRef="Matt.7.28-Matt.7.29 Luke.4.31-Luke.4.37">Mt 7,28-29; Lc 4,31-37 </reference></title>
<p>
<verse sID="Mark.1.21" osisID="Mark.1.21" n="21" /><w lemma="strong:G2532">Et</w>
adyeths commented 4 years ago

Should be fixed now.

LAfricain commented 4 years ago

Doesn't work for me :(

<!-- s2 --><title>Une journée à Capharnaüm</title>
<verse eID="Mark.1.20" />
<!-- r --><title type="parallel"><reference type="parallel">(Mt 7,28-29; Lc 4,31-37)</reference></title>
<p>
<verse sID="Mark.1.21" osisID="Mark.1.21" n="21" /><w lemma="strong:G2532">Et</w> ils <w lemma="strong:G1531">entrèrent</w> <w lemma="strong:G1519">à</w> <w lemma="strong:G2584">Capharnaüm</w>, <w lemma="strong:G2532">et</w> <w lemma="strong:G2112">dès</w> <w lemma="strong:G3588">le</w> <transChange type="added">jour du
adyeths commented 4 years ago

I'm going to need a source that contains multiple titles in order to test and fix this then.

LAfricain commented 4 years ago

Ok, you can use this file. You have multiples titles and parallel ref.

adyeths commented 4 years ago

The verse end tags in relation to titles should be fixed now. I had forgotten about the comments preceding titles which caused the movement of verse end tags not to work properly. That is fixed now.

LAfricain commented 4 years ago

Very well! It works.