search

adyscorpius / logseq-jira

A simple Jira plugin for Logseq users
MIT License
38 stars 11 forks source link

Fix on-premise API bugs #11

Closed plamendelchev closed 3 months ago

plamendelchev commented 3 months ago

The following PR fixes two bugs I encountered while using the plugin with an on-premise JIRA instance.

I have tested the changes and can confirm that the plugin works as intended with them.

adyscorpius commented 3 months ago

Hi.. I'm looking back at the original commit by @nightscape .

Is this something that is an alternative way to access on-premise API? There seems to be two types of authentication flows (Personal access tokens and Bearer auth). Is that accurate?

plamendelchev commented 3 months ago

Hi, yes you are correct. The on-promise API can be accessed both with OAuth and Basic Authentication: https://developer.atlassian.com/server/jira/platform/security-overview/ I personally use Basic Authentication, but I did not take into account that OAuth is also a valid option, so maybe my changes have not addressed the issue fully.

adyscorpius commented 3 months ago

Just went through the documentations again and funnily Basic and Bearer both work in the cloud, so there's no way of testing this stuff really.

But I've made it highly configurable now. Hopefully this new version solves for both PAT and Basic Authentication use cases. I don't think supporting OAuth makes much sense with PAT.

Happy if you all can test it out. Release v0.3.0 now.