search

adyscorpius / logseq-jira

A simple Jira plugin for Logseq users
MIT License
40 stars 11 forks source link

feat: Allow configuring JIRA REST API version #6

Closed nightscape closed 5 months ago

nightscape commented 1 year ago

This allows working with some on-premise instances.

HansAndreManfredson commented 7 months ago

Same over here. I need to define the Version of the Rest-API to you the plugin onpremise. Would be great if you could merge the request!!!

jwhonce commented 5 months ago

@nightscape Thanks for making this PR. I was able to tweak a local copy of logseq-jira based on your work. Saves me effort and time when taking meeting minutes.

adyscorpius commented 5 months ago

@nightscape Thanks for making this PR. I was able to tweak a local copy of logseq-jira based on your work. Saves me effort and time when taking meeting minutes.

That's wonderful. Would you want to update the pull request with working code?

nightscape commented 5 months ago

I just rebased to the newest version in master. @jwhonce did you need further modifications?

jwhonce commented 5 months ago

@nightscape Just had some time to try the new release from marketplace. I am getting 401's with the latest release. When I get more time I will update my repository and see if I can find the difference. Thank you for all your hard work.

adyscorpius commented 5 months ago

Can you switch between Bearer and PAT in settings and try again?

jwhonce commented 5 months ago

@adyscorpius That changed the return code to 403's. I also turned off auto-update since it is experimental

I had a chance to pull up the devtools and can see Basic authorization is being used even when PAT is set in the settings.

  "jiraAuthType": "PAT",
  "jiraAPIVersion": "2",

while the header showed Basic vs. Bearer. My javascript fu is too weak to determine from the code what is happening.

adyscorpius commented 5 months ago

Found the issue and released the fix in v0.4.1.

It should work for you now. Please confirm if it does.