Update to Mongoid 3 - Githubissues

adzap / validates_timeliness

Date and time validation plugin for ActiveModel and Rails. Supports multiple ORMs and allows custom date/time formats.

MIT License

1.59k stars 227 forks source link

Update to Mongoid 3 #104

Closed johnnyshields closed 9 years ago

johnnyshields commented 11 years ago

Now requires Mongoid 3.0 as minimum version (this is the only version to support Rails 3.2; Mongoid 2 is very outdated and few plugins continue to support it.)
Upgrade specs/helpers for Mongoid 3
Support Mongoid aliased field names (e.g. field :foo, as: bar, type: String). Includes spec
Support before_type_cast on Mongoid. No code change was required for this, only a spec change.
There was one mongoid spec that was previously marked pending. I've found that it now works on Mongoid 3.
Removed some Mongoid 2.3 and earlier hacks, which simplifies the Mongoid ORM code.

johnnyshields commented 11 years ago

@adzap please take a look at this

adzap commented 9 years ago

I'd really like to pull out mongoid support. I don't use it and don't imagine I will again.

Are you interested in ripping out the mongoid support and putting it in your own gem?

johnnyshields commented 9 years ago

@adzap possibly in the future, but you would be able to merge this as-is?

adzap commented 9 years ago

@johnnyshields I'd prefer not to. This current version will become Rails 3.x only. Moving to Rails 4.x I want to strip out extensions which have a dependency outside of Rails version.

johnnyshields commented 9 years ago

@adzap it would make sense to merge this as it provides a solution for Rails 3 users on Mongoid (Mongoid 3 == Rails 3). Rails 4 works with Mongoid 4, etc.

adzap commented 9 years ago

@johnnyshields Ok sorry. Gotcha. I will merge.

johnnyshields commented 9 years ago

Thanks!