Closed AquisTech closed 6 years ago
@adzap The code fix is working as I am using the code in my application. But Travis CI is failing. Please let me know how should I configure tests for Rails 5.x
I had done changes for Travis CI but reverted as this branch is not meant for that purpose. I am creating separate issue and will raise PR for changes to stabilize Travis CI build.
So the code for multi-parameter code is actually in ActiveRecord::AttributeAssignment
not ActiveModel
. Given the is a ActiveRecord only feature I am inclined to keep in the ActiveRecord namespace.
The whole approach of reopening the module is something I want to move away from, but for now I get these bugs fixed and then we can refactor some things.
Closing this an keeping the version I have already.
But thanks for these PRs coming in. I'm just reviewing them now.
@adzap Thanks for the review.
Fix issue#164 Enable multiparameter_extension issue in Rails 5
Reason for this issue was following change:
Reference: second point in Rails 5.0 Release Notes