search

adzap / validates_timeliness

Date and time validation plugin for ActiveModel and Rails. Supports multiple ORMs and allows custom date/time formats.
MIT License
1.59k stars 227 forks source link

Fix issue#164 Enable multiparameter_extension issue in Rails 5 #165

Closed AquisTech closed 6 years ago

AquisTech commented 6 years ago

Fix issue#164 Enable multiparameter_extension issue in Rails 5

Reason for this issue was following change:

  • Extracted ActiveRecord::AttributeAssignment to ActiveModel::AttributeAssignment allowing to use it for any object as an includable module. (Pull Request)

Reference: second point in Rails 5.0 Release Notes

AquisTech commented 6 years ago

@adzap The code fix is working as I am using the code in my application. But Travis CI is failing. Please let me know how should I configure tests for Rails 5.x

AquisTech commented 6 years ago

I had done changes for Travis CI but reverted as this branch is not meant for that purpose. I am creating separate issue and will raise PR for changes to stabilize Travis CI build.

adzap commented 6 years ago

So the code for multi-parameter code is actually in ActiveRecord::AttributeAssignment not ActiveModel. Given the is a ActiveRecord only feature I am inclined to keep in the ActiveRecord namespace.

The whole approach of reopening the module is something I want to move away from, but for now I get these bugs fixed and then we can refactor some things.

Closing this an keeping the version I have already.

adzap commented 6 years ago

But thanks for these PRs coming in. I'm just reviewing them now.

AquisTech commented 6 years ago

@adzap Thanks for the review.