search

adzap / validates_timeliness

Date and time validation plugin for ActiveModel and Rails. Supports multiple ORMs and allows custom date/time formats.
MIT License
1.59k stars 227 forks source link

Cleanup: Remove DateTimeValue class #174

Closed AquisTech closed 6 years ago

AquisTech commented 6 years ago

@adzap I found that this class is not needed (I may be wrong here) but as I checked and tested I found the code to be working without DateTimeValue class. Passing values hash is enough. Not sure where and when the change method was being invoked. I am using code by removing class and it is working fine. Please review and merge PR.

adzap commented 6 years ago

Are you running the specs with this removed?

Also the code using your values has was failing for the reasons I explained in your comment about the POSITION keys.

Before any more issues or PRs please run the specs.