search

adzap / validates_timeliness

Date and time validation plugin for ActiveModel and Rails. Supports multiple ORMs and allows custom date/time formats.
MIT License
1.59k stars 227 forks source link

Add Rails 6.0 appraisal #191

Closed vsppedro closed 3 years ago

vsppedro commented 4 years ago

Hi, I hope you are doing fine.

Just noticed that the file Appraisals is missing version 6.0 of Rails. This PR was created in case you want this configuration.

About the changes:

I tried to run the tests with 'sqlite3', '~> 1.3.6' in all the version, but unfortunately, I got theses errors:

An error occurred while loading spec_helper. - Did you mean?
                    rspec ./spec/spec_helper.rb

Failure/Error: ActiveRecord::Base.establish_connection({:adapter => 'sqlite3', :database => ':memory:'})

LoadError:
  Error loading the 'sqlite3' Active Record adapter. Missing a gem it depends on? can't activate sqlite3 (~> 1.4), already activated sqlite3-1.3.13. Make sure all dependencies are added to Gemfile.

There is an issue about this problem on Rails 6: https://github.com/rails/rails/issues/35153

And the solution is to update to 'sqlite3', '~> 1.4.0'.

What do you think?

And again, thanks for this awesome gem.

adzap commented 3 years ago

thanks for this, but has been covered by another PR.