Closed schinery closed 2 years ago
Btw I looked through the tests but wasn't sure if anything covered this or not. If you want me to update or write a new one for this lemme know.
Thanks but the validator specs should cover it given it add errors internally and the issue should have showed up already. I'm interested in why it hadn't.
@adzap is it worth setting up GitHub actions to run the specs for Ruby 2.7 and 3?
Yes. Looks like we need to move off Travis to GitHub actions anyway. Any help in doing that would be appreciated. On 26 Nov 2021, 9:11 PM +1100, Stuart Chinery @.***>, wrote:
@adzap is it worth setting up GitHub actions to run the specs for Ruby 2.7 and 3? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
@adzap sure thing, I've added the config for GitHub actions to run the tests as part of this PR if that's ok? Also threw in the Dependabot config too
Here are the specs running for both Ruby 2.7 and 3.0.
Excellent thanks! So ruby 3.0 is passing. Weird.
Do you know how to add the appraisal gemfiles into the actions matrix? On 27 Nov 2021, 12:16 AM +1100, Stuart Chinery @.***>, wrote:
@adzap sure thing, I've added the config for GitHub actions to run the tests as part of this PR (if that's cool?) and threw in the Dependabot config too. Here are the specs running for both Ruby 2.7 and 3.0. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
Ignore me I was looking this on my phone and now realise it's part of the PR to fix it also. I will merge.
Fix for https://github.com/adzap/validates_timeliness/issues/204