Closed petergoldstein closed 1 year ago
Screenshot showing that Ruby 3.1.x is being loaded for the Ruby 3.0 entries in CI:
@adzap let's merge this
Hi, isn't this a partial duplicate of #213 ?
@tagliala There's some overlap. But this PR both adds Ruby 3.1 and fixes the broken Ruby 3.0 entries in the CI matrix.
I've pushed a version of the deprecation fix to this branch.
Is there someone with merging permissions on this repo?
This PR supersedes #218, #214, and #213 and closes #217, #221, and (partially) #222
I'm asking before making a temporary fork with the changes needed to add this gem in a Rails 7 project
@tagliala - I'm in a similar boat; planning to just run off of @petergoldstein's (or rather, a fork from that branch). Will report back with how it works on a Ruby 3.0 + Rails 7.0 production application in a couple weeks.
@adzap would you be willing to designate Peter Goldstein as a backup maintainer here so we can get a fixed release out?
@zspencer feel free to use this branch: https://github.com/tagliala/validates_timeliness/tree/rails-70
I've just protected it and I'm using it in an application
Also, it is based on this PR, plus the usual validates_timeliness approach (= remove 6.x compatibility)
I appreciate the offer, but from a supply-chain security perspective, I tend to prefer deploying my own forked branch over relying on someone else's so that deploys don't accidentally pull in un-audited code.
Thanks but there was too much in this PR and it does not conform to the convention of a major version per ActiveRecord major version, so pushed necessary changes in other commits.
In addition to adding Ruby 3.1 and Rails 7 to the CI configuration, this PR: