search

adzap / validates_timeliness

Date and time validation plugin for ActiveModel and Rails. Supports multiple ORMs and allows custom date/time formats.
MIT License
1.59k stars 227 forks source link

Comparison to ComparisonValidator #233

Closed espen closed 1 year ago

espen commented 1 year ago

Will this gem still be relevant after Rails 7.1? ComparisonValidator will make it possible to do the core features of this gem. While validates_timeliness is excellent I am wondering if there is any reason to use it after this new Rails feature?

https://github.com/rails/rails/pull/40095

espen commented 1 year ago

https://blog.kiprosh.com/rails7-activerecord-comparison-validator/

adzap commented 1 year ago

I guess I’ll be out of job. On 15 Jun 2023 at 12:03 AM +1000, Espen Antonsen @.***>, wrote:

https://blog.kiprosh.com/rails7-activerecord-comparison-validator/ — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

tagliala commented 9 months ago

I've eventually moved to the built-in comparison validator

Relevant changes:

https://github.com/diowa/icare/commit/dd4a4677ab8b0f9aaf8fdcc2e3a05877480efb8d#diff-8f06df7d19040b42d0ab94249895f10fac375834ce5a6f4e55b93570b9dd7d8fL26-R27

Thanks for all these years!