search

adzerk-oss / boot-cljs-repl

Boot task providing a REPL for ClojureScript development.
Eclipse Public License 1.0
72 stars 28 forks source link

outdated piggieback dependency? #60

Open OlafMerkert opened 6 years ago

OlafMerkert commented 6 years ago

It seems to me that com.cemerick/piggieback has been superseded by cider/piggieback. At least cider itself seems to be of that opinion. Should the dependency be updated?

arichiardi commented 6 years ago

See #61

arichiardi commented 6 years ago

I would say things are still evolving but I see that these deps will need to be updated for it to work:

https://github.com/adzerk-oss/boot-cljs-repl/blob/master/src/adzerk/boot_cljs_repl.clj#L18-L21

Another nice thing to do would probably be to read the current deps coming from build.boot and take those in case. The deps in the snipped above should be the default but not the only ones we consider.

bbatsov commented 6 years ago

It seems to me that com.cemerick/piggieback has been superseded by cider/piggieback. At least cider itself seems to be of that opinion. Should the dependency be updated?

Btw, despite of the namespace that's not something to do with CIDER. At the time when the project was handed over to me the nREPL org didn't still exist and this seem like a reasonable coordinate for the artefact. I would have chosen nrepl/piggieback if I were doing this today, but it is what it is.