search

adzerk-oss / bootlaces

Adzerk's boot configurations for Clojure libraries
Eclipse Public License 1.0
44 stars 18 forks source link

remove hardcoded referenc to src dir #17

Closed jumblerg closed 5 years ago

jumblerg commented 7 years ago

i assume there must be some reason the directory "src" was hardcoded, but it seems this should be obtained from the boot environment. the hoplon/ui build broke when i moved the sources from "src" to "lib/src"; this patch fixes it.

jumblerg commented 7 years ago

after making the pr i noticed the very same patch has been submitted several times previously. patching it was faster than navigating all the history. this might not be the right solution, but something doesn't seem quite right about the way things are currently configured either.

it seems that the usage of bootlaces has evolved beyond what it was conceived to be; maybe a similar project should be created in boot-clj, or perhaps these tasks should be incorporated into boot itself.

jumblerg commented 7 years ago

see issue #9.

arichiardi commented 7 years ago

@jumblerg there is a typo in the key there. It is a tough one for sure, it seems something specific is needed as :resources role for things to work, did not investigate more than just a quick look do your change though

allentiak commented 5 years ago

@markjfisher With the suggestion I just did, this should be now ready to be merged.

Closes #9.

allentiak commented 5 years ago

Ping... @alandipert?, @daveyarwood?, @jgrimes?, @karnowski?, @onetom?, @pkobrien?...

daveyarwood commented 5 years ago

This PR looks good to me -- @jumblerg if you could fix the typo (soure-paths => source-paths) I'll merge this.

daveyarwood commented 5 years ago

Actually, never mind -- I just saw #20 which is the same thing but with the typo fixed -- merged that one.