search

adzerk-oss / bootlaces

Adzerk's boot configurations for Clojure libraries
Eclipse Public License 1.0
44 stars 18 forks source link

GPG signing should be a configurable param? (breaks on Win) #19

Open robjens opened 6 years ago

robjens commented 6 years ago

Seems like it isn't. Now I tried making a GPG private key but it won't work from my Git Bash on Windows due to no tty.

Also, Clojars doesn't check GPG (anymore) - probably has something to do with lack of awareness amongst developers I would guess.

Anyway, should I want to use bootlaces on Windows, due to access modifiers / scoping, I am forced to implement my own push-release since I won't be able to simply override and change namespace references. boot.git last-commit is clean enough (one-liner), get-creds another one/two-liner. Finally collect-clojars-credentials also needs to be copied to the local build.boot file in order to simply be able to use :gpg-sign false. This is somewhat inconvenient.

Addition of a task parameter to push-release to flag to enable (or disable if true is to be the default) gpg-sign would make it much cleaner imho.

This is how I worked around the problem: https://github.com/robjens/boot-reframe-10x/blob/dc8466ddf36f53e29df0319a37eec9002b60e9dc/build.boot#L36

allentiak commented 5 years ago

Maybe opening a PR could help advancing this?