search

adzerk-oss / bootlaces

Adzerk's boot configurations for Clojure libraries
Eclipse Public License 1.0
44 stars 18 forks source link

Creates tag before successful deploy #6

Closed zilti closed 9 years ago

zilti commented 9 years ago

Bootlaces already creates the git tag before the deploy to clojars is successful. Should it fail, subsequent tries will fail due to the already-existing tag.

micha commented 9 years ago

I'm not sure we want boot to be deleting tags itself, do we? I'm not sure what the correct behavior is when the clojars thing fails.

zilti commented 9 years ago

I'd suggest to create the tag after the clojars deploy has been successful.

micha commented 9 years ago

Haha, oh right. That makes sense. I was thinking that we were putting the tag in the pom.xml file, but in fact we only put the SHA of the commit in there. So the tag isn't a critical part of the deployment process really. I'll make the necessary modifications.