adzerk / adzerk-ios-sdk

Access Adzerk's ad serving APIs via iOS
https://www.adzerk.com
Other
9 stars 5 forks source link

Support multi-winner request & response [breaking change!] #18

Closed karnowski closed 3 years ago

karnowski commented 4 years ago

Background

Adzerk has added support for "multiple winners" for each placement on an ad request. There are a LOT of use cases for this, and there is a LOT that goes on under the covers to make it work, but suffice it to say that each placement has an optional count parameter that indicates the maximum number of winners it wants. Each decision returned then has zero or more selections. The Android and iOS SDKs, however, were built before multi-winner and so only expects each decision to ever have only zero or one selections. (There isn't even a concept of "selection" in these SDKs as a result.)

Note that in the Swagger-generated SDKs we've moved to always returning an array of selections inside a decision, even for non-multi-winner requests. We expect the same will be necessary in the mobile SDKs, and that this will be a breaking change. (However, as breaking changes go, this one isn't a lot of work for integrating developers to respond to.)

Acceptance Criteria