adzerk / adzerk-ios-sdk

Access Adzerk's ad serving APIs via iOS
https://www.adzerk.com
Other
9 stars 5 forks source link

Support for recording impressions #30

Closed subdigital closed 3 years ago

subdigital commented 3 years ago

Dependent on #25

karnowski commented 3 years ago

@subdigital This will still send the X-Adzerk-Sdk-Version header, right? We still want it to report adzerk-decision-sdk-ios:[version].

karnowski commented 3 years ago

To be clear -- as long as the header is sent, then I approve this PR!

subdigital commented 3 years ago

After looking at this again, should this be on userDB instead? We already have a (private) method for sending a fire-and-forget pixel request...

karnowski commented 3 years ago

No, impression pixels are not associated with UserDB.

subdigital commented 3 years ago

@subdigital This will still send the X-Adzerk-Sdk-Version header, right? We still want it to report adzerk-decision-sdk-ios:[version].

I had forgotten to bring this over, but it's there now. All requests will have this.

subdigital commented 3 years ago
image