search

adzerk / adzerk-ios-sdk

Access Adzerk's ad serving APIs via iOS
https://www.adzerk.com
Other
9 stars 5 forks source link

Reporting incorrect version #37

Closed karnowski closed 3 years ago

karnowski commented 3 years ago

Background

The Kevel SDKs report their version to the Kevel servers using the X-Adzerk-Sdk-Version header. The intent is to identify both the SDK and the numeric version for customer support and product prioritization purposes.

Starting in either 1.1.0 or 1.2.0 the iOS SDK started reporting as the following: adzerk-ios-decision-sdk:1.2.0 . The version here is correct, but the SDK name was inconsistent with the rest of our SDK identifier strings.

For 2.0.0, I personally changed the SDK identifier string to adzerk-decision-sdk-ios to be consistent with our other SDKs. However, it appears that something in the 2.0 or 2.0.1 packaging changes broke the version number in this header.

The Bug

The iOS SDK version 2.0.1 is reporting adzerk-decision-sdk-ios:1.0.0 but we expect to see adzerk-decision-sdk-ios-2.0.1. Note it's unclear as of this writing but I'm assuming that the 2.0.0 version was also incorrectly reporting 1.0.0 as well.

Acceptance Criteria