Swift 3 conversion for the workspace.

adzerk / adzerk-ios-sdk

Access Adzerk's ad serving APIs via iOS

https://www.adzerk.com

Other

9 stars 5 forks source link

Swift 3 conversion for the workspace. #8

Closed AnttiLaitinenVincit closed 7 years ago

AnttiLaitinenVincit commented 7 years ago

Converted the SDK, sample app and tests to Swift 3 syntax.

I tested that the sample app worked OK and also ran the SDK tests. Only test that failed was:

AdzerkSDKTests.testCanRequestPlacementwithAllParameters() (row 191)

I suspect this is not due to the swift 3 conversion, as I checked the raw decision response string and it did not contain the wanted property (content.template!). So that is probably something with the request params / ad setup rather than a SDK problem.

EdSancha commented 7 years ago

Would love to see this integrated too 👍

karnowski commented 7 years ago

We're internally reviewing and should hopefully get this merged soon! Thanks so much for your contribution!

subdigital commented 7 years ago

This looks good! I have a few minor adjustments that I've made on my branch, but I'll go ahead and merge this in.