search

adzialocha / hoffnung3000

Platform for decentralized, anonymized, self-curated festivals
https://hoffnung3000.de
GNU Affero General Public License v3.0
36 stars 8 forks source link

Venue registration: all slots disabled by default #58

Closed sandreae closed 4 years ago

sandreae commented 5 years ago

Slots disabled by default and enabled when selected. Slightly more intuitive for users.

sandreae commented 5 years ago

I'm having a go at making this change, thought it might involve changing this value from "false" to "true" but no joy so far. Am I in the right area?

https://github.com/adzialocha/hoffnung3000/blob/b0f0a3018eca0a0411d25f3fceb084aeedd55222/common/utils/slots.js#L110

adzialocha commented 4 years ago

The database currently only stores used slots, to be more efficient. To get all slots be turned on by default requires a) filling the database with active slots for each event or b) changing the database logic to only hold disabled slots (much better).

Yeah, this requires then changes in the overall logic how a slot is represented internally.

sandreae commented 4 years ago

Ah, sorry, I wasn't clear.

I'm suggesting that when registering a venue all slots should be disabled by default.

sandreae commented 4 years ago

This is needed because many of the venues registering for the festival will only have maybe a couple of periods where they are available within the week long festival. So in this case there are a lot of slots to disable.....

adzialocha commented 4 years ago

I see! Still what I've written in the above comment counts. Disabled slots are currently stored in the database, I suggest to change the logic then to storing only active slots when changing the default.

adzialocha commented 4 years ago

This is implemented now as a Toggle button!