search

adzialocha / hoffnung3000

Platform for decentralized, anonymized, self-curated festivals
https://hoffnung3000.de
GNU Affero General Public License v3.0
36 stars 8 forks source link

Feature: Add a config option to make all events publicly viewable #63

Closed sandreae closed 4 years ago

sandreae commented 4 years ago

This is a feature to make all events viewable to non-registered visitors. This is needed in cases where the entire festival program should be viewable without registering as a visitor on the platform.

adzialocha commented 4 years ago

Right now we are checking if a festival is free by comparing the festivalTicketPrice configuration to 0, for example here: https://github.com/adzialocha/hoffnung3000/blob/79398a0c2fc1b6686d57959dc8b3c1f55b561cf1/app/scripts/components/TicketWizard.js#L122-L128

You might just want to use this instead of introducing a new configuration field, also seems more intutive to me as there is less options involved (what happens if you set the ticket price to 0 but forgot to turn on "is festival free")?

adzialocha commented 4 years ago

Also I can see ticketUrl changes in this PR from the other PR? :-) make sure to branch out from master for new features, or I suggest making a "development" branch and merge subchanges against this first before going to master.

sandreae commented 4 years ago

Yeh, i was just thinking that there could be a case where ticket price is set to 0 but you still wanted people to log in to see the events. So the it would be good to have them separate. Maybe that's unlikely though.