ae-utbm / sith

🌐 The website of the AE
https://ae-utbm.github.io/sith/
GNU General Public License v3.0
6 stars 4 forks source link

Inconsitent promotion logo Size #110

Closed Juknum closed 2 years ago

Juknum commented 2 years ago

In GitLab by @aile on Nov 10, 2021, 13:16

We should create a script that resizes automatically newly uploaded promotion logos in 200x200 🤔.

That would delete image size inconsistency and improve workflow.

Suggestions are well appreciated 😁

Juknum commented 2 years ago

In GitLab by @aile on Nov 17, 2021, 21:44

changed due date to November 24, 2021

Juknum commented 2 years ago

In GitLab by @tinople on Nov 18, 2021, 01:23

I think it would be easier to just limit the size directly using CSS rather than making a script, like that we could use higher resolutions images for logos without any issue

Juknum commented 2 years ago

In GitLab by @aile on Nov 18, 2021, 10:15

It will increase page loading time. The idea would be to let a promotion office upload its logo, then to resize it in a standardized size (600x600 for instance, it doesn't have to be a small size).

It will speed up the process of uploading a new logo without the hassle to ask the IT manager of the AE (often not known when a new fall semester begins)

Juknum commented 2 years ago

In GitLab by @aile on Nov 18, 2021, 10:15

The 200x200 idea was for caching the logo in pages like the user page, counter pages, ...

Juknum commented 2 years ago

In GitLab by @tinople on Nov 19, 2021, 13:16

Can I have some screenshots where we can see this issue? would be easier to debug

Juknum commented 2 years ago

In GitLab by @aile on Nov 19, 2021, 15:31

Screenshot_20211119-153247

Juknum commented 2 years ago

In GitLab by @tinople on Nov 19, 2021, 18:41

Ok, should be fixed on the front-redisign-A21 branch
image

Juknum commented 2 years ago

In GitLab by @tinople on Nov 19, 2021, 18:42

Wait my bad it's not the same content xd I'll look into that then

Juknum commented 2 years ago

In GitLab by @tinople on Dec 2, 2021, 12:20

Fixed in https://ae-dev.utbm.fr/ae/Sith/-/commit/7b0624386670dcd5a938104d909700512627c28c