Forum search - [merged]

[Juknum]

In GitLab by @sli on Dec 5, 2018, 14:07

Merges feature/forum-search -> master

Liste des features

• [x] Une recherche utilisable
• [x] Gestion des permissions
• [x] Un indexage qui fonctionne en prod
• [x] Un update automatique de l'index lors de l'ajout d'un message (gestion du signal)
• [x] Une vitesse de recherche inférieure à 3 secondes
• [x] Une recherche jolie

[Juknum]

In GitLab by @sli on Dec 5, 2018, 14:17

added 1 commit

• 90222d88 - Adapt forum search to xapian and improve query

Compare with previous version

[Juknum]

In GitLab by @sli on Dec 5, 2018, 14:49

added 1 commit

• 14d3ab29 - Add some flags to make XAPIAN more fuzzy

Compare with previous version

[Juknum]

In GitLab by @sli on Dec 5, 2018, 17:56

added 4 commits

• aba42074 - 1 commit from branch master
• 41c0bead - Add haystack index, and a view for forum search (WIP)
• b385995f - Adapt forum search to xapian and improve query
• 330d2e4a - forum: make search fuzzy

Compare with previous version

[Juknum]

In GitLab by @sli on Dec 5, 2018, 18:18

added 1 commit

• cab24c29 - forum: display search bar on every forum pages

Compare with previous version

[Juknum]

In GitLab by @sli on Dec 6, 2018, 14:23

added 1 commit

• 6eab9253 - forum and core: add access rights on search query

Compare with previous version

[Juknum]

In GitLab by @sli on Dec 6, 2018, 14:30

added 1 commit

• 9e063516 - forum and core: add access rights on search query

Compare with previous version

[Juknum]

In GitLab by @skia on Dec 6, 2018, 15:09

Commented on forum/models.py line 334

You'll have to be very careful about performances with this change, because it may make the Forum completely unusable...

[Juknum]

In GitLab by @skia on Dec 6, 2018, 15:10

Commented on core/views/init.py line 1

A specialized view would be certainly better than this generic one, I think.

[Juknum]

In GitLab by @skia on Dec 6, 2018, 15:13

Commented on forum/views.py line 57

The right checking could be done here, by evaluating each result item, storing their IDs (or not if permission denied), then returning a new QuerySet with filter(id__in=my_id_list)

[Juknum]

In GitLab by @sli on Dec 7, 2018, 11:28

Commented on forum/views.py line 57

I think it's better here to just return nothing and not a permission denied since it's a search query

[Juknum]

In GitLab by @skia on Dec 7, 2018, 11:35

Commented on forum/views.py line 57

I never mentioned that the user would face a PermissionDenied... I was saying that you could store the IDs that don't trigger PermissionDenied, which is completely different.

[Juknum]

In GitLab by @sli on Dec 7, 2018, 11:36

added 1 commit

• 05698be1 - forum and core: add a dedicated mixin to exclude unauthorized search results

Compare with previous version

[Juknum]

In GitLab by @sli on Dec 7, 2018, 11:38

Commented on forum/views.py line 57

Oh, yes, I misread that

[Juknum]

In GitLab by @skia on Dec 7, 2018, 11:39

Commented on core/views/init.py line 198

You shall not remove that 2, or you'll run into troubles!

[Juknum]

In GitLab by @sli on Dec 7, 2018, 11:40

Commented on core/views/init.py line 198

Oups

[Juknum]

In GitLab by @sli on Dec 7, 2018, 11:42

Commented on core/views/init.py line 198

changed this line in version 9 of the diff

[Juknum]

In GitLab by @sli on Dec 7, 2018, 11:42

added 1 commit

• 3d5f13b7 - core: fix typo

Compare with previous version

[Juknum]

In GitLab by @sli on Dec 7, 2018, 11:50

Commented on forum/models.py line 334

changed this line in version 10 of the diff

[Juknum]

In GitLab by @sli on Dec 7, 2018, 11:50

Commented on forum/views.py line 57

changed this line in version 10 of the diff

[Juknum]

In GitLab by @sli on Dec 7, 2018, 11:50

added 1 commit

• 005f1659 - forum and core: remove CanViewSearchMixin and use specialized view instead

Compare with previous version

[Juknum]

In GitLab by @sli on Dec 7, 2018, 13:16

added 1 commit

• e45be20c - forum: limit results and improve search engine speed

Compare with previous version

[Juknum]

In GitLab by @sli on Dec 7, 2018, 13:35

added 2 commits

• c83fa2e7 - forum: better display of search results
• 5d544265 - forum and core: fix error 500 when query is empty on search

Compare with previous version

[Juknum]

In GitLab by @sli on Dec 7, 2018, 13:55

added 1 commit

• e70d0cf6 - forum: workaround for building index

Compare with previous version

[Juknum]

In GitLab by @sli on Dec 7, 2018, 14:29

added 1 commit

• 44f295cb - forum: workaround for building index

Compare with previous version

[Juknum]

In GitLab by @sli on Dec 7, 2018, 14:37

added 1 commit

• 0a56fbe5 - forum: workaround for building index

Compare with previous version

[Juknum]

In GitLab by @sli on Dec 10, 2018, 10:46

added 1 commit

• e00f81bc - forum: workaround for error while indexing badly encoded text (legacy)

Compare with previous version

[Juknum]

In GitLab by @sli on Dec 10, 2018, 13:20

added 1 commit

• 235ec35c - forum: workaround for building index, use convert instead of prepare

Compare with previous version

[Juknum]

In GitLab by @sli on Dec 10, 2018, 14:43

added 1 commit

• 57d3d487 - forum: workaround for building index with safety margin

Compare with previous version

[Juknum]

In GitLab by @sli on Dec 10, 2018, 16:06

added 1 commit

• 4dd3e60b - forum: add trigger to update index on ForumMessage update

Compare with previous version

[Juknum]

In GitLab by @sli on Dec 10, 2018, 16:06

marked the task Un update automatique de l'index lors de l'ajout d'un message (gestion du signal) as completed

[Juknum]

In GitLab by @sli on Dec 11, 2018, 14:03

added 1 commit

• 2d49e341 - forum: workaround size error while building index, handle malformed utf8

Compare with previous version

[Juknum]

In GitLab by @sli on Dec 11, 2018, 14:20

marked the task Un indexage qui fonctionne en prod as completed

[Juknum]

In GitLab by @Soldat on Dec 11, 2018, 20:09

added 1 commit

• 5c69d21e - changed design

Compare with previous version

[Juknum]

In GitLab by @skia on Dec 12, 2018, 10:13

Commented on core/views/init.py line 46

Useless import

[Juknum]

In GitLab by @sli on Dec 12, 2018, 15:32

Commented on core/views/init.py line 46

changed this line in version 22 of the diff

[Juknum]

In GitLab by @sli on Dec 12, 2018, 15:32

added 1 commit

• 8ece8254 - forum: increase search speed by optimizing permission filter

Compare with previous version

[Juknum]

In GitLab by @sli on Dec 12, 2018, 15:48

added 2 commits

• d70cd7f5 - forum: improve search bar UX behavior
• cf74e8be - forum: implement order by date for search

Compare with previous version

[Juknum]

In GitLab by @sli on Dec 12, 2018, 16:48

added 1 commit

• f6cd7fb4 - forum: use pure jinja for search bar

Compare with previous version

[Juknum]

In GitLab by @sli on Dec 12, 2018, 16:54

added 1 commit

• 2dfd86a3 - forum: use pure jinja for search bar

Compare with previous version

[Juknum]

In GitLab by @sli on Dec 13, 2018, 10:13

added 1 commit

• ec0844f7 - forum: fix order by date

Compare with previous version

[Juknum]

In GitLab by @skia on Dec 13, 2018, 10:54

Commented on forum/templates/forum/macros.jinja line 161

I think you wanted class="search_check"

[Juknum]

In GitLab by @skia on Dec 13, 2018, 10:56

Commented on locale/fr/LC_MESSAGES/django.po line 4422

Not a very clean translation... Maybe "Pas de résultats" would be better. Then you'll be able to remove the "fuzzy"

[Juknum]

In GitLab by @sli on Dec 13, 2018, 14:07

Commented on forum/templates/forum/macros.jinja line 161

changed this line in version 27 of the diff

[Juknum]

In GitLab by @sli on Dec 13, 2018, 14:08

Commented on locale/fr/LC_MESSAGES/django.po line 4422

changed this line in version 27 of the diff

[Juknum]

In GitLab by @sli on Dec 13, 2018, 14:08

added 3 commits

• 4a566027 - forum: fix typo in search bar checkbox class name
• 37f18f6d - forum: fix translation when no search result found
• ea0c889a - forum: use generic macro to display breadcrumb and display it on search result

Compare with previous version

[Juknum]

In GitLab by @sli on Dec 13, 2018, 14:16

marked the task Une recherche jolie as completed

[Juknum]

In GitLab by @sli on Dec 13, 2018, 14:16

unmarked as a Work In Progress

[Juknum]

In GitLab by @skia on Dec 13, 2018, 18:15

added 2 commits

• cd78be30 - core: put User.group's names in cache
• 62e2b111 - forum/views: reduce number of queries with some 'prefetch_related'

Compare with previous version

[Juknum]

In GitLab by @skia on Dec 13, 2018, 20:45

added 29 commits

• 62e2b111...a96aeba1 - 2 commits from branch master
• 9b8a8819 - Add haystack index, and a view for forum search (WIP)
• 286ba91c - Adapt forum search to xapian and improve query
• 404b825d - forum: make search fuzzy
• 525b047b - forum: display search bar on every forum pages
• 3fdb83c1 - forum and core: add access rights on search query
• 076b10e3 - forum and core: add a dedicated mixin to exclude unauthorized search results
• 1de77f2f - core: fix typo
• 884855c1 - forum and core: remove CanViewSearchMixin and use specialized view instead
• 107c6c19 - forum: limit results and improve search engine speed
• 65a0b7b2 - forum: better display of search results
• 347caa3b - forum and core: fix error 500 when query is empty on search
• 545671be - forum: workaround for building index
• 26924260 - forum: workaround for error while indexing badly encoded text (legacy)
• ee99ec1a - forum: workaround for building index with safety margin
• 641d564e - forum: add trigger to update index on ForumMessage update
• 57454bff - forum: workaround size error while building index, handle malformed utf8
• a9bae46f - changed design
• e421a2b4 - forum: increase search speed by optimizing permission filter
• 721b22a1 - forum: improve search bar UX behavior
• 68911749 - forum: implement order by date for search
• fc7e4519 - forum: use pure jinja for search bar
• 068a8051 - forum: fix order by date
• 82ffd753 - forum: fix typo in search bar checkbox class name
• 84811af9 - forum: fix translation when no search result found
• af3e2fb9 - forum: use generic macro to display breadcrumb and display it on search result
• 82df4241 - core: put User.group's names in cache
• 835782fd - forum/views: reduce number of queries with some 'prefetch_related'

Compare with previous version

[Juknum]

In GitLab by @skia on Dec 13, 2018, 20:56

enabled an automatic merge when the pipeline for 835782fd7e53a38f81dd867ca40c5abb9aa36fd4 succeeds