Improved Elections CSS for the table - [merged]

[Juknum]

In GitLab by @tinople on Jun 15, 2022, 01:54

Merges election-css -> master

• Everything can be seen without scrolling sideways (unless you're on a small screen)
• Each column makes the same size
• Candidate description/program is now below its profile picture
• If the candidate does not have any profile picture, the default one is shown
• The Edit/Delete message has been replaced with their corresponding emojis (they takes fewer spaces and doesn't need to be translated)
• Modified links at the bottom to look like buttons

Before


This MR (root)


This MR (lambda user)


When a candidate is selected


[Juknum]

In GitLab by @tinople on Jun 15, 2022, 01:54

requested review from @aile

[Juknum]

In GitLab by @tinople on Jun 15, 2022, 01:54

requested review from @L_Sacienne and removed review request for @aile

[Juknum]

In GitLab by @tinople on Jun 15, 2022, 01:54

requested review from @aile and removed review request for @L_Sacienne

[Juknum]

In GitLab by @tinople on Jun 15, 2022, 01:58

added 1 commit

• 066ca5ba - This shouldn't be unminified

Compare with previous version

[Juknum]

In GitLab by @skia on Jun 15, 2022, 09:15

Commented on election/templates/election/election_detail.jinja line 9

Moving all this to a separate file is a very great idea, but to keep thing consistent, it should be in the election namespace instead of core.

[Juknum]

In GitLab by @skia on Jun 15, 2022, 09:15

Commented on core/static/core/election.scss line 1

Wouldn't this be better in rem or similar relative unit?
Same for the many px that are being used across this file.

[Juknum]

In GitLab by @tinople on Jun 15, 2022, 15:29

resolved all threads

[Juknum]

In GitLab by @tinople on Jun 15, 2022, 15:32

Commented on election/templates/election/election_detail.jinja line 9

changed this line in version 3 of the diff

[Juknum]

In GitLab by @tinople on Jun 15, 2022, 15:32

Commented on core/static/core/election.scss line 1

changed this line in version 3 of the diff

[Juknum]

In GitLab by @tinople on Jun 15, 2022, 15:32

added 1 commit

• 85788977 - Moved file to correct place & improved CSS a bit

Compare with previous version

[Juknum]

In GitLab by @tinople on Jun 15, 2022, 15:41

@skia double-check? :eyes:

[Juknum]

In GitLab by @skia on Jun 15, 2022, 16:04

Yep, I already did it and thumbed up, but I didn't take the time for a real review, I only had a very quick look. If you want me to approve, I can do it though. :-)

Nice work on this one, I'll be glad to have a look at other work you may want to take ;)

[Juknum]

In GitLab by @tinople on Jun 15, 2022, 16:07

resolved all threads

[Juknum]

In GitLab by @L_Sacienne on Jun 15, 2022, 21:06

approved this merge request

[Juknum]

In GitLab by @L_Sacienne on Jun 15, 2022, 21:13

mentioned in commit 3e8f1acb961a2a36354cec63352d4c769ab2e1c4