search

aeakoski / scrapy

Scrapy, a fast high-level web crawling & scraping framework for Python.
https://scrapy.org
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Add branch coverage _link_allowed #6

Closed fliljeda closed 6 years ago

fliljeda commented 6 years ago

Add branch coverage for function _link_allowed in file scrapy/linkextractors/init.py

dskeppstedt commented 6 years ago

5/6 branches is covered

dskeppstedt commented 6 years ago

This is the branch that is never taken

def _link_allowed(self, link):
        if not _is_valid_url(link.url):
            return False

# rest of function is removed for brevity
dskeppstedt commented 6 years ago

did I do good @aeakoski