search

aecreations / clippings

Clippings: an extension for Mozilla Firefox
20 stars 4 forks source link

REGRESSION: No error notification, and Clippings context menu contains duplicate items if Sync Clippings Helper uninstalled #425

Closed aecreations closed 1 year ago

aecreations commented 1 year ago

Clippings 6.3b1+ on Firefox 114.0.2

A regression issue, possibly caused by a recent change in Firefox.

Steps to repro:

  1. Install Sync Clippings helper app
  2. Turn on Sync Clippings
  3. Exit Firefox
  4. Uninstall Sync Clippings helper app
  5. Start Firefox

Result: The error notification about unable to connect to Sync Clippings helper app doesn't appear. Also, when opening the Clippings context menu, there are duplicate items.

The developer tools console shows the following error:

image
aecreations commented 1 year ago

This issue is related to #416. The fix for that issue needs to be applied to the background script (in function refreshSyncedClippings()) as well as in the script for the New Clipping dialog.

aecreations commented 1 year ago

Bug fix is confirmed in Clippings 6.5rc1.

aecreations commented 1 year ago

The fix also needs to be done in Clippings Manager, in function handlePushSyncItemsError().

aecreations commented 1 year ago

Yet another fix is needed, because Clippings Manager function handlePushSyncItemsError() doesn't handle the sync error properly.

aecreations commented 1 year ago

This is confirmed to be fully fixed in Clippings 6.5rc3.