search

aecreations / clippings

Clippings: an extension for Mozilla Firefox
20 stars 4 forks source link

In Clippings Manager, synced items in menu message box overlaps reload sync folder message box #500

Open aecreations opened 1 week ago

aecreations commented 1 week ago

Clippings 7.0b3+

This is a long-standing bug with Sync Clippings, but is noticeable due to the new Clippings Sidebar.

Steps to repro:

  1. Turn on Sync Clippings, but leave settings at default
  2. Open Clippings Manager
  3. Open the Sidebar, then click Reload on the Synced Clippings folder. Dismiss the message box in the sidebar, but leave the "Reload sync folder" message box open in Clippings Manager
  4. Return to extension preferences and turn on the option to show only the synced items in the Clippings menu. Clicking OK in the dialog will cause the Synced Clippings folder to be automatically reloaded
  5. Return to Clippings Manager. Notice that the message box informing users about the "Show only synced items" setting takes over, and the "Reload sync folder" message box isn't dismissed
  6. Now dismiss the "Show only sync items" message box

Result: The message box is dismissed, but the "Reload sync folder" message box remains on screen, with the dark lightbox overlay gone. image

aecreations commented 1 week ago

Currently, the "Show only sync items" message box appears when Clippings Manager is opened, or when the clippings tree is rebuilt right after the setting is turned on. (Afterwards, a pref is set to ensure it only appears once.)

The fix should be applied to when the clippings tree is rebuilt. To fix this bug:

  1. Before showing the "Show only sync items" message box, check if there are any dialogs currently open. If there are, don't show the message box.
  2. Exception: The "Reload sync folder" message box is open. In this case, wait until the message box is closed, then show the "Show only sync items" message box after a brief delay (~500 ms).