Adapting Pokemon Showdown

[aed3]

This is a list of functions in the two Pokemon Showdown folders this project is adapting (sim and dex) that will, should, and might have its logic completely changed. The functions are also listed for their main reason for changing. To discuss a function in depth, a separate issue can be created directly from this list. I'll be editing this list as ideas change.

Priority 1 (Will Change)

• [x] #3
• [x] Battle.toJSON/fromJSON [Performance] (copying battle states was resolved by #2)
• [x] PRNG.sample [Functionality] (resolved by #2)
• [x] #2
• [x] Battle.speedSort [Functionality]
• [x] #6
• [x] Battle.randomizer [Functionality] (resolved by #2)
• [x] #7
• [x] Battle.go [Functionality] (resolved by #2)
• [x] #5
• [x] #4

Priority 2 (Should Change)

• [x] BattleQueue.resolveAction [Performance]
• [ ] BattleActions.useMove (and helper functions) [Performance][Functionality]
• [ ] Dex___.getByID [Performance]
• [ ] Pokemon.calculateStat/getStat [Performance]
• [ ] Battle.boost [Performance][Functionality]
• [ ] Battle.spreadDamage [Performance][Functionality]
• [ ] Side.chooseMove [Functionality]
• [ ] Side.chooseSwitch [Functionality]
• [ ] Side.chooseTeam [Functionality]
• [ ] Battle.start [Functionality]

Priority 3 (Might Change)

• [ ] ModdedDex.getEffectiveness [Performance][Functionality]
• [ ] Pokemon.transformInto [Performance][Functionality]
• [ ] Pokemon.setStatus [Performance]
• [ ] Pokemon.addVolatile [Performance]
• [ ] Pokemon.effectiveWeather [Performance]
• [ ] Pokemon.runEffectiveness [Performance]
• [ ] Pokemon.runImmunity [Performance]
• [ ] Pokemon.runStatusImmunity [Performance]
• [ ] Pokemon.transformInto [Functionality]

[aed3]

With all the Priority 1 functions planned out, it's time to start working on the vertical slice!