aedenthorn / StardewValleyMods

GNU General Public License v3.0
98 stars 114 forks source link

MagnetMod optimization -or- question #34

Closed sketchbook22 closed 2 years ago

sketchbook22 commented 2 years ago

I suspect extra code is running.

Stardew Valley has code: Debris.updateChunks()

Which it seems like your mod has modified slightly (to support your various features) ModEntry.UpdateTicking()

If I'm reading this correctly, both methods would be running. I would have thought this would be another Harmony Prefix.

I am new to modding and suspect you have a reason that I am not aware of; and would like to learn your reason if you have time. Thanks.

aedenthorn commented 2 years ago

the idea was to run the movement x - 1 times and let the updateChunks run the movement a final time. It's kind of ugly, but it does allow for a movement multiplier

sketchbook22 commented 2 years ago

Understood, thank you for responding.