search

aedm / minimeteor

Dockerize Meteor applications.
43 stars 13 forks source link

DOCs: are there CI Tests? Badges? #14

Open 0o-de-lally opened 7 years ago

0o-de-lally commented 7 years ago

It was mentioned there were CI tests. Can you post the status or badges of which node/meteor versions this is tested against?

aedm commented 7 years ago

I have no badges unfortunately, since it's a completely custom test framework. It builds test images and runs them on a VPS, not on CircleCI or anything similar. If they run successfully, they are pushed to Docker Hub. Here are the images it tested so far: https://hub.docker.com/r/aedm/minimeteor-buildtest/tags/

I'm open to adding any badges to the readme. What kind of badges do you think would make sense? One I found was this, but it's not related to tests: https://img.shields.io/docker/pulls/aedm/minimeteor.svg

0o-de-lally commented 7 years ago

I think it would be valuable for the community to see the builds on CircleCi or other. Specifically CircleCi allows you to use docker images now for building, so maybe it could streamline your build process. https://circleci.com/docs/1.0/docker/

aedm commented 7 years ago

Unfortunately, CircleCI doesn't have the features I need to test it. When I push a new version, the test server fetches the list of Meteor releases from GitHub, and runs the test against all versions. This process takes several hours. If any of the tests fails, it's automatically retried forever until it succeeds, this protects agains issues like network outages. I understand that a CircleCI badge looks nice, but I can't do all that on Circle.

0o-de-lally commented 7 years ago

I'm just interested in a process that the community can reproduce. I'm not sure everything you need, but circleci 2.0 will have more docker features. https://circleci.com/beta-access/

ethanwillis commented 7 years ago

I don't think CircleCI is necessary. But I do agree with the sentiment that it would be nice to make tests reproducible for the community.

aedm commented 7 years ago

You're right, these tests need to be reproducible. The code is here: https://gitlab.com/aedm/meteor-crawler

It's really hackish at the moment, but I'll just leave it here to show it's not a secret. It's going to take some time to clean them up and write a manual.