aegean-odyssey / mpmd_marlin_1.1.x

a fork of Marlin firmware (bugfix-1.1.x) for the Monoprice MP Mini Delta 3d printer
GNU General Public License v3.0
76 stars 19 forks source link

PID tune typo? #94

Closed BackwardEcho closed 2 years ago

BackwardEcho commented 2 years ago

PID Autotune finished! Put the last Kp, Ki and Kd constants from below into Configuration.h #define DEFAULT_Kp 32.84 #define DEFAULT_Ki 1.53 #define DEFAULT_Kd 176.22 ok P63 B7 echo:Unknown command: "MM105"

Just finished a PID tune and it occurred to me that MM105 is a typo, as M105 is an actual command related to temperature reporting.

aegean-odyssey commented 2 years ago

I spent some time looking at this bug, and it seems some kind of miscommunication after the PID command finishes. Possibly, the input buffer is garbled (the initial "M" maybe hanging around) or the command is improperly sent from the controlling side. Not quite sure how to proceed on this one.

BackwardEcho commented 2 years ago

It's not all that important as it doesn't prevent the printer from printing, so no need to proceed if you can't figure it out. But I do feel stupid for not thinking pronterface could be sending that bad command. I mean, it does say "echo:" what should be a reply from the printer, right?