search

aegypius / overlay

Gentoo overlay
http://aegypius.github.io/overlay/
31 stars 8 forks source link

clang requirement for atom-shell #53

Closed sarnex closed 9 years ago

sarnex commented 9 years ago

Hi, this is more of a question than an issue. Why is clang required from atom-shell? No clang packages are installed by default in atom, and I removed the requirement manually from atom-shell and everything builds and works fine. Is there any reason to have it, it increases my LLVM build time, and is a nightmare to get working using the llvm-999 ebuild.

Thanks alot, sarnex

aegypius commented 9 years ago

Hi @sarnex, I don't think I am the best to tell if clang is really required in atom-shell, I simply followed the Build instructions (Linux) from atom/electron repository and updated dependencies to try to match gentoo packages.

Node.js Clang 3.4 or later Development headers of GTK+ and libnotify

from Atom Shell/Electron documentation

These instructions may be outdated, if so you should report directly to atom/electron repository.

I will try to build atom without clang flag and provide a binary alternative.

sarnex commented 9 years ago

@aegypius Ok, thanks alot

sarnex commented 9 years ago

Atom guys say you need it. Thanks

aegypius commented 9 years ago

Your welcome !

On ven., mai 08, 2015 at 3:35 PM, sarnex < notifications@github.com [notifications@github.com] > wrote: Atom guys say you need it. Thanks

— Reply to this email directly or view it on GitHub [https://github.com/aegypius/overlay/issues/53#issuecomment-100235730] .[https://github.com/notifications/beacon/AABkbidKbZYATtkLPIJkLgiUAJoGSeOqks5oHLMFgaJpZM4EQlEQ.gif]