Replace colon in output PNG filenames with dash

aeirola / react-native-svg-asset-plugin

Asset plugin for importing SVG images in React Native

https://www.npmjs.com/package/react-native-svg-asset-plugin

MIT License

68 stars 9 forks source link

Replace colon in output PNG filenames with dash #28

Closed zs-doron closed 4 years ago

zs-doron commented 5 years ago

Fix issue #27 by replacing the colon used in filenames for the PNG output files by a dash

aeirola commented 4 years ago

Thanks for the PR. The change looks good, but still requires the tests to be fixed as well. Should be just a matter of replacing the colon with dashes in the test filenames.

zs-doron commented 4 years ago

Sorry for the extra work, I did not realize there were tests (should not have committed in the evening).

(Edit) I closed the PR by mistake, sorry for that!

aeirola commented 4 years ago

No worries. Code looks good, I'll go ahead and merge it.