Closed papigers closed 4 years ago
Thanks for the PR! In general looks good, but would maybe be good to discuss the configuration format a bit.
The react-native default tooling, such as jest (https://jestjs.io/docs/en/configuration#testregex-string--arraystring), flow (https://flow.org/en/docs/config/ignore/) and metro (https://facebook.github.io/metro/docs/configuration/#blacklistre) all seem to prefer using RegExps over other formats such as the .gitignore
pattern. So while I also personally do like the gitignore pattern format, I'm a bit cautious about deviating from the convention set by the react native tooling.
What kind thoughts does this provoke for a fellow react native developer?
For me personally glob patterns are more readable and easier to understand. But I see where you're coming from, I'll try to update the PR tomorrow to use regex instead.
Hope that's better :)
Thanks again. I'll do some chores on the repo, and the release this promptly.
This is now released in version 0.4.0. Thanks again for the help!
Awesome! Thank you!
Solves #40
ignorePatterns
option to ignore certain SVG files from processing (blacklist).includePatterns
option to process only certain files (whitelist).These options cannot be used together.