Do not send CTCP notifications for actions

aeirola / slack-irc-client

Use Slack as your IRC client

88 stars 16 forks source link

Do not send CTCP notifications for actions #16

Closed yokuyuki closed 7 years ago

yokuyuki commented 8 years ago

Actions on IRC seem to send both an action and a CTCP ACTION
The latter is rather annoying since it goes straight to Slackbot and sends notifications for it

What it looked like in logs:

verbose: IRC: Received CTCP privmsg from yokuyuki to #test ACTION rolls
verbose: IRC: New action from yokuyuki to #test: rolls

This change mutes that CTCP

yokuyuki commented 8 years ago

aeirola commented 8 years ago

Good catch, thanks for the pull request. I'm wondering if the matcher should more closely follow the logic in node-irc at https://github.com/martynsmith/node-irc/blob/v0.5.0/lib/irc.js#L1122. At the moment, for example the, imaginary, CTCP command ACTION_MOVIES_LIST would not be sent to slack with the current logic.

yokuyuki commented 8 years ago

Although I think it's unlikely that another ctcp command with ACTION will exist, it's probably safer to split the text in the suggested match fashion. Fixed now.

ayufan commented 7 years ago

@aeirola Can you review it once again? It's quite annoying :)

aeirola commented 7 years ago

Sorry for the wait. I don't really use this package anymore, so not really actively maintaining it at the moment. Will be happy to merge some requests and make a release though.