Handle ternary operators and angular filters with arguments

aeisenberg / angular-bind-notifier

On demand refreshing of AngularJS bindings. Vast performance improvements on complex apps.

http://aeisenberg.github.io/angular-bind-notifier/

MIT License

111 stars 13 forks source link

Handle ternary operators and angular filters with arguments #25

Closed AntoineEsteve closed 8 years ago

AntoineEsteve commented 8 years ago

The current version doesn't allow to use the angular-bind-notifier with ternary operators and filters with arguments.

First case, ternary operators : {{:namespace:(varA?varB:varC)}} varA?varB is not a namespace, it is part of the expression.

Other case, filters with arguments : {{:namespace:(varA|orderBy:varB:varC)}} (varA|orderBy is not a namespace, it is part of the expression.

kasperlewau commented 8 years ago

Hey man, cheers for the PR!

Would you mind writing up some unit tests covering these new cases before merging?

For reference, here are the contributing guidelines.

kasperlewau commented 8 years ago

@AntoineEsteve What's the status on this one?

kasperlewau commented 8 years ago

I'll go ahead and close this for the time being given that #26 was just merged and released, which partly(fully?) takes care of the changes requested.