search

aeisenberg / angular-bind-notifier

On demand refreshing of AngularJS bindings. Vast performance improvements on complex apps.
http://aeisenberg.github.io/angular-bind-notifier/
MIT License
111 stars 13 forks source link

Fix #29 Leading whitespace in watch expression still causes parse error #30

Closed lrajlich closed 7 years ago

lrajlich commented 8 years ago

Passed linter and tests

Lukes-MacBook-Pro-2:angular-bind-notifier lukerajlich$ gulp test [13:01:27] Using gulpfile ~/Projects/dealpath/angular-bind-notifier/gulpfile.js [13:01:27] Starting 'test'... 23 05 2016 13:01:27.671:INFO [karma]: Karma v0.13.22 server started at http://localhost:8067/ 23 05 2016 13:01:27.680:INFO [launcher]: Starting browser PhantomJS 23 05 2016 13:01:28.751:INFO [PhantomJS 1.9.8 (Mac OS X 0.0.0)]: Connected on socket /#Hn7JasSFI_znHlVZAAAA with id 55332580 PhantomJS 1.9.8 (Mac OS X 0.0.0): Executed 65 of 65 SUCCESS (14.406 secs / 14.156 secs) [13:01:43] Finished 'test' after 16 s

kasperlewau commented 8 years ago

Specs passed on rebuild - but I'd like for you to supply some new unit tests covering the fixed case(s) before merging this in. @lrajlich

kasperlewau commented 7 years ago

Closing due to inactivity.